Skip to content

Fix BulkInferenceExecutorTests timeout caused by a race condition. #130991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 31, 2025

Conversation

afoucret
Copy link
Contributor

@afoucret afoucret commented Jul 10, 2025

Manual backport of a race condition fixed as part of #131986

Fixes #130306 that is a symptom of that.

@elasticsearchmachine elasticsearchmachine added v9.2.0 needs:triage Requires assignment of a team area label labels Jul 10, 2025
@afoucret afoucret added :Analytics/ES|QL AKA ESQL v9.1.0 and removed needs:triage Requires assignment of a team area label v9.2.0 labels Jul 10, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jul 10, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@afoucret afoucret added >test Issues or PRs that are addressing/adding tests and removed Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Jul 10, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jul 10, 2025
@benwtrent
Copy link
Member

@afoucret is the test muted? Maybe unmute with this fix if this indeed fixes it?

@afoucret afoucret enabled auto-merge (squash) July 11, 2025 16:42
@afoucret
Copy link
Contributor Author

@benwtrent The test is unmuted.

@afoucret afoucret changed the base branch from main to 9.1 July 31, 2025 07:31
@afoucret afoucret requested review from a team as code owners July 31, 2025 07:31
@afoucret afoucret changed the base branch from 9.1 to main July 31, 2025 07:39
@afoucret afoucret force-pushed the fix-bulkinference-test-timeout branch from f8ca794 to a68115d Compare July 31, 2025 07:53
@afoucret afoucret changed the base branch from main to 9.1 July 31, 2025 07:54
Copy link
Contributor

🔍 Preview links for changed docs

More links …

@afoucret afoucret changed the title Fix BulkInferenceExecutorTests timeout failures by reducing test load and increasing min thread pool size Fix BulkInferenceExecutorTests timeout caused by a race condition. Jul 31, 2025
@kc13greiner
Copy link
Contributor

@afoucret I see we are tagged for review, did you mean to tag ES Security? Im happy to review regardless - I just dont want you to miss their input if you were looking for it!

@afoucret afoucret removed request for a team July 31, 2025 13:21
@afoucret
Copy link
Contributor Author

@kc13greiner I do not know why ES security has been tagged. Definitely not intended.

@afoucret afoucret disabled auto-merge July 31, 2025 13:44
Copy link
Contributor

@tteofili tteofili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@afoucret afoucret merged commit 0ee4c18 into elastic:9.1 Jul 31, 2025
34 checks passed
@afoucret afoucret added auto-backport Automatically create backport pull requests when merged v8.19.0 labels Jul 31, 2025
afoucret added a commit to afoucret/elasticsearch that referenced this pull request Jul 31, 2025
@afoucret
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.19

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] BulkInferenceExecutorTests testSuccessfulExecution failing
5 participants